Skip to content

util: Drop redundant NDEBUG check #20274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

util: Drop redundant NDEBUG check #20274

wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 30, 2020 •
edited
Loading

The util/check.h does this job:

bitcoin/src/util/check.h

Lines 45 to 47 in 42b66a6

#if defined(NDEBUG)
#error "Cannot compile without assertions!"
#endif

maflcko
maflcko reviewed Oct 30, 2020
View reviewed changes
@hebasto
util: Drop redundant NDEBUG check
7c6d8ff 
util/check.h does this job.
@fanquake
Copy link
Member

NOTE: If this does get merged we'll also need to update the stripbuildinfo.patch

@practicalswift
Copy link
Contributor

The goal of src/compat/assumptions.h is to document all system assumptions we make we make.

The assumption that the macro NDEBUG is not defined is an important such assumption, so please don't remove the NDEBUG documentation from src/compat/assumptions.h :)

@hebasto hebasto closed this Oct 31, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@maflcko maflcko maflcko left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @fanquake @practicalswift @maflcko