Skip to content

build, msvc: Drop duplicated common\url.cpp source file #29976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2024
Merged

build, msvc: Drop duplicated common\url.cpp source file #29976

merged 1 commit into from
Apr 27, 2024

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 26, 2024

After #29904, the common\url.cpp source file is included into the SOURCE_FILES by the msvc-autogen.py script.

Removes a compiler warning:

url.obj : warning LNK4006: "class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > __cdecl UrlDecode(class std::basic_string_view<char,struct std::char_traits<char> >)" (?UrlDecode@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$basic_string_view@DU?$char_traits@D@std@@@2@@Z) already defined in common_url.obj; second definition ignored [D:\a\bitcoin\bitcoin\build_msvc\libbitcoin_common\libbitcoin_common.vcxproj]

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 26, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

fanquake
fanquake approved these changes Apr 27, 2024
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 97a4ad5

@fanquake fanquake merged commit 7fee0ca into bitcoin:master Apr 27, 2024
@hebasto hebasto deleted the 240426-msvc-url branch April 27, 2024 06:53
@bitcoin bitcoin locked and limited conversation to collaborators May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

Assignees
No one assigned
Labels
Build system Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @DrahtBot @fanquake