[26.x] archive 26.1 release notes + backports #29899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid issues with DNS blacklisting, I've setup a separate domain for my DNS seed. Github-Pull: bitcoin#29691 Rebased-From: 4f273ab
Github-Pull: bitcoin#29869 Rebased-From: c2e0489
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
…oint Github-Pull: bitcoin#28554 Rebased-From: 9ac114e
dasibcryptoidology
approved these changes
Apr 28, 2024
b467fd5 to
cb3ed23
Compare
This was referenced May 13, 2024
cb3ed23 to
59cf8f7
Compare
This was referenced May 14, 2024
59cf8f7 to
636588d
Compare
|
Propose the first commit of #30085 for backport. |
636588d to
715d4e0
Compare
715d4e0 to
a29e9e5
Compare
stickies-v
approved these changes
May 23, 2024
There was a problem hiding this comment.
ACK a29e9e5 modulo release notes touchup
All backport commits are clean, except for:
- b148146: because of #28955
- 109b9d7: because of LLVM version bump in #29659
- 7d13e6a: because of removing -rpcserialversion (#28890, and #28438)
All of these look good to me.
nit: in b148146 commit message, it should be Github-Pull: #29776 instead of Github-Pull: #29767
Github-Pull: bitcoin#29776 Rebased-From: bbe82c1
The issue is that compilation is done with `x86_64-w64-mingw32-g++-posix`, but then linking is done with `x86_64-w64-mingw32-g++`. I'm guessing this has been broken since bitcoin#24131 (01d1845), but have not checked. Fixes bitcoin#29734. Unblocks bitcoin#29527 (now DEBUG=1 builds can be tested). Github-Pull: bitcoin#29747 Rebased-From: b7e7e72
The script provided for signature might be externally provided, for instance by way of 'finalizepsbt'. Therefore the script might be ill-crafted, so don't assume pubkeys are always 32 bytes. Thanks to Niklas for finding this. Github-Pull: bitcoin#29853 Rebased-From: 4d8d213
Re-enable feature_init Github-Pull: bitcoin#29856 Rebased-From: fadf7e9
Pretty much all library packages were renamed in the 64-bit time_t migration to add `t64` (even on 64-bit platforms). Instead of complicating the doc with conditional package names, suggest installing the `-dev` packages which still have the same name, and besides that, are the right way to go about it as they contain the "user facing" C++ headers needed to build against Qt5. For Fedora, devel packages are already suggested. This affects Ubuntu 24.04 and Debian Testing. Github-Pull: bitcoin#29764 Rebased-From: a3c6a13
Fix CI build for t64 migration. Github-Pull: bitcoin#29764 Rebased-From: 6c29904
The 32 to 64-bit time_t transition causes a build failure in the built-in zlib about conflicting _TIME_BITS and _FILE_OFFSET_BITS. Note that zlib doesn't use time_t at all, so it is a false alarm. Take the following patch from upstream zlib: https://github.com/madler/zlib/commit/a566e156b3fa07b566ddbf6801b517a9dba04fa3.patch Closes bitcoin#29980. Github-Pull: bitcoin#29985 Rebased-From: 2e266f3
Without explicitly declaring the move, these UniValues get copied, causing increased memory usage. Fix this by explicitly moving the UniValue objects. Used by `rest_block` and `getblock` RPC. Github-Pull: bitcoin#30094 Rebased-From: b77bad3
Github-Pull: bitcoin#29870 Rebased-From: fa6ab0d
Github-Pull: bitcoin#30149 Rebased-From: 9f4ff1e
Addnode (manual) peers connected to us via the cjdns network are currently not detected by CConnman::GetAddedNodeInfo(), i.e. fConnected is always false. This causes the following issues: - RPC `getaddednodeinfo` incorrectly shows them as not connected - CConnman::ThreadOpenAddedConnections() continually retries to connect them Github-Pull: bitcoin#30085 Rebased-From: 684da97
a29e9e5 to
aa7e876
Compare
|
Thanks so much @stickies-v! Nice catch, fixed the transifex line and PR number |
|
re-ACK aa7e876, only changes are fixing commit msg and transifex reference |
willcl-ark
approved these changes
May 24, 2024
There was a problem hiding this comment.
ACK aa7e876
Checked that all backports were applied without modifcation where possible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Archives 26.1 release notes and adds draft release notes for 26.2rc1
Also backports: