log: Remove error() reference #29633
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
src/logging.h
Outdated
| @@ -215,7 +215,7 @@ static inline bool LogAcceptCategory(BCLog::LogFlags category, BCLog::Level leve | |||
| /** Return true if str parses as a log category and set the flag */ | |||
| bool GetLogCategory(BCLog::LogFlags& flag, const std::string& str); | |||
|
|
|||
| // Be conservative when using LogPrintf/error or other things which | |||
| // Be conservative when using LogPrintf or other things which | |||
There was a problem hiding this comment.
LogPrintf is deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.
There was a problem hiding this comment.
re: #29633 (comment)
LogPrintfis deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.
FWIW #29256 just deletes this comment, which is not near any of the logging functions and I doubt anyone will see. It is replaced by documentation for the new logging macros.
There was a problem hiding this comment.
I have removed the LogPrintf reference as well.
FWIW #29256 just deletes this comment
Cool! If that was further along I would simply drop this PR here but I am not clear if the discussion there is fully resolved yet. So I am keeping this open for now but if this stays open longer and #29256 collects ACKs, feel free to close it.
src/logging.h
Outdated
| @@ -215,7 +215,7 @@ static inline bool LogAcceptCategory(BCLog::LogFlags category, BCLog::Level leve | |||
| /** Return true if str parses as a log category and set the flag */ | |||
| bool GetLogCategory(BCLog::LogFlags& flag, const std::string& str); | |||
|
|
|||
| // Be conservative when using LogPrintf/error or other things which | |||
| // Be conservative when using LogPrintf or other things which | |||
There was a problem hiding this comment.
re: #29633 (comment)
LogPrintfis deprecated, according to the dev notes, so when touching this line, it could be fixed up as well, to avoid having to touch this again, soon after.
FWIW #29256 just deletes this comment, which is not near any of the logging functions and I doubt anyone will see. It is replaced by documentation for the new logging macros.
1ebcd43 to
d0e6564
Compare
Mini-followup to #29236 that was just merged. Removes a reference to
error()that was missed in a comment.