test: fix a race in rpc_net.py (wait for P2P handshake to complete) #29515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We connect a new peer, wait for it using `self.nodes[0].wait_for_new_peer()`
and then demand that "transport_protocol_type" is either "v1" or "v2".
However `wait_for_new_peer()` may return too early - during the P2P handshake
when "transport_protocol_type" is "detecting".
Fix this by waiting for the P2P handshake to complete and the protocol
version to be established.
An example failure (equal fields removed for clarity):
```
AssertionError: not({
...
'session_id': '',
'transport_protocol_type': 'detecting',
} == {
...
'session_id': '8fe5902166b892a57ac6849caadd02d2dff83d84f2e57ee50bf894f93cf2f62e',
'transport_protocol_type': 'v2',
})
```
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
|
Generally, it is good to check the open pull requests before opening a pull request, to avoid duplicate patches for the same fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We connect a new peer, wait for it using
self.nodes[0].wait_for_new_peer()and then demand that "transport_protocol_type" is either "v1" or "v2". Howeverwait_for_new_peer()may return too early - during the P2P handshake when "transport_protocol_type" is "detecting".Fix this by waiting for the P2P handshake to complete and the protocol version to be established.
An example failure (equal fields removed for clarity):
https://cirrus-ci.com/task/5839860502626304?logs=ci#L8326