[26.x] backports and final changes for v26.1rc2 #29509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MinGW-w64 toolchain links executables to the old msvcrt C Runtime Library that does not support the `x` modifier for the _wfopen() function. Github-Pull: bitcoin#29357 Rebased-From: d2fe905
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
I think #29510 should be backported too, once it's merged. |
hebasto
approved these changes
Feb 29, 2024
Github-Pull: bitcoin#29412 Rebased-From: 95bddb9
Github-Pull: bitcoin#29412 Rebased-From: e7669e1
Github-Pull: bitcoin#29412 Rebased-From: 66abce1
Github-Pull: bitcoin#29412 Rebased-From: 2d8495e
We preemptively perform a block mutation check before further processing a block message (similar to early sanity checks on other messsage types). The main reasons for this change are as follows: - `CBlock::GetHash()` is a foot-gun without a prior mutation check, as the hash returned only commits to the header but not to the actual transactions (`CBlock::vtx`) contained in the block. - We have observed attacks that abused mutated blocks in the past, which could have been prevented by simply not processing mutated blocks (e.g. bitcoin#27608). Github-Pull: bitcoin#29412 Rebased-From: 49257c0
Github-Pull: bitcoin#29412 Rebased-From: 5bf4f5b
Slight performance improvement by avoiding duplicate work. Github-Pull: bitcoin#29412 Rebased-From: 1ec6bbe
Github-Pull: bitcoin#29412 Rebased-From: d8087ad
…v block Github-Pull: bitcoin#29524 Rebased-From: a1fbde0
…Destination` fails Github-Pull: bitcoin#29510 Rebased-From: 367bb7a
…`getnewaddress` failures Github-Pull: bitcoin#29510 Rebased-From: e073f1d
|
Can you also add #29529. |
Should fix the GCC compilation portion of bitcoin#29517: bitcoin#29517 (comment). See also: https://www.gnu.org/software/gnulib/manual/html_node/fopencookie.html but note that FreeBSD has supported this function since 11.x. Github-Pull: bitcoin#29529 Rebased-From: 312f338
77e2466 to
b6d006d
Compare
|
Added #29529. Also updated release notes and added final changes for rc2. |
|
ACK c68d4d0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes:
xmodifier infsbridge::fopencall for MinGW builds #29357getrawchangeaddressandgetnewaddressfailures should not affect keypools for descriptor wallets #29510Also does: