Skip to content

Conversation

jessebarton
Copy link
Contributor

@jessebarton jessebarton commented Feb 26, 2024

Updated OpenBSD Build doc for 7.4 after testing all build options. No issues on my end.

Also added a note about referring to depends/README.md for detailed instructions on required dependencies.
This was added in reference to a conversation in #29443

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 26, 2024

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake, theStack

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Feb 26, 2024
@jessebarton
Copy link
Contributor Author

@theStack Thanks for the suggestion on bumping and testing a fresh build with OpenBSD 7.4.

Feel free to review my changes and add any suggestions/feedback, also If there is anything else Documentation related you can think of that needs attention let me know!

@fanquake fanquake changed the title doc: Update OpenBSD build docs to 7.4 and added link to the depends/R… doc: Update OpenBSD build docs for 7.4 Feb 26, 2024
@fanquake
Copy link
Member

Can you fixup the commit message:

Commit messages should be verbose by default consisting of a short subject line (50 chars max)

Tested and used all build options on OpenBSD 7.4 with no issues.

Added a note about referring to depends/README.md for detailed instructions on required dependencies.
This was added in reference to a conversation in bitcoin#29443
@jessebarton jessebarton force-pushed the update-openbsd-build-docs branch from bc31c4b to fccfdb2 Compare February 26, 2024 16:06
@fanquake
Copy link
Member

ACK fccfdb2

@fanquake fanquake requested a review from theStack February 27, 2024 11:15
Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ACK fccfdb2

@fanquake fanquake merged commit 6a7ed5e into bitcoin:master Feb 27, 2024
@bitcoin bitcoin locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants