lint: Fix lint-whitespace issues #29487
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Does this PR allow dropping |
|
I think it should be dropped, but that can be done in a follow-up, unrelated to the bugfixes here. |
|
Concept ACK |
fa68024 to
fa67aad
Compare
fa67aad to
fa57294
Compare
| fn lint_tabs_whitespace() -> LintResult { | ||
| let tabs = git() | ||
| .args(["grep", "-I", "--line-number", "--perl-regexp", "^\\t", "--"]) | ||
| .args(["*.cpp", "*.h", "*.md", "*.py", "*.sh"]) |
There was a problem hiding this comment.
This list is pretty limited. Would adding .rs to it make sense?
There was a problem hiding this comment.
Sure, it can be added. I tried to keep everything as-is, except for the bugfixes. I may add it, if I have to re-touch.
The lint check has many issues:
COMMIT_RANGE, which is brittle code, apparently making it harder to run the CI locally, or self-hosted. See Fix issues with CI on forks #29274 (comment)COMMIT_RANGE, or the number of commits passed to the script, which can cause false negatives or false positives.Fix all issues by removing the script and replacing it with a simple call to
git grep -I --line-number ....