rpc: method removeprunedfunds should take an array of txids #29468
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
da1a32a to
10a5742
Compare
|
Concept ACK |
10a5742 to
771920d
Compare
771920d to
4fa1ad3
Compare
|
Probably better to just remain backward compatible, at least for a release or two...? |
It could handle both cases I guess (passing a string as arg and an array of strings). |
|
Actually, looking at the implementation deeper, I'm not sure we gain anything from this change. Just use batch RPC calls? Concept NACK for now. |
Doing batches of RPC calls is definitely slower than if we handled this case internally. So how is that not a benefit? |
Do you have any performance analysis to look into the difference between both approaches? That would be helpful to assess the merit of this PR. |
|
Are you still working on this? The comment about backwards compatibility was never addressed. |
This PR addresses issue #29466 by updating the
removeprunedfundsRPC method to accept an array of transaction IDs (txids). This enhancement allows for batch removal of transactions, improving usability for pruned wallets. The change includes updates to the RPC method signature and the corresponding functional test adjustments to align with the new input format. This feature simplifies wallet management by enabling more efficient transaction handling.