fuzz: avoid underflow in coins_view target
#29164
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
|
|
My bad, i ran the new |
On what commit? For me it seems to pass on current master. |
|
You need to add the sanity check to trigger it. |
|
Sigh... I'm tired of this target just doing random things. Turns out you can't perform the sanity checks because it's using a dummy backend where |
Catching the exception in
AddCoinand continuing will lead to the calculated memory usage of the cache to be out of sync (lower by the size of the existing coin). If we later remove more coins, this can lead to an underflow and the sanitizer will trip on a later overflow when we add back tocachedCoinsUsage. See #28216 (comment).I found this while rebasing #28216 but another way of exposing this mistake is to simply run the cache sanity check after the
LIMITED_WHILEloop. This PR fixes the underflow by not continuing when hitting this exception and adds the sanity check.The crash can be reproduced with the following seed: