Skip to content

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Dec 9, 2023

Turns out "class template argument deduction for aggregates" is one of the few things implemented only in recent compilers, see https://en.cppreference.com/w/cpp/compiler_support/20

So clarify the comments.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 9, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Dec 9, 2023
@maflcko maflcko force-pushed the 2312-doc20- branch 2 times, most recently from facb041 to fa1dce9 Compare December 18, 2023 14:50
@maflcko
Copy link
Member Author

maflcko commented Dec 18, 2023

Included #29108

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa87f8f, I verified the code with clang-{16,17}.

@maflcko maflcko requested a review from fanquake January 5, 2024 13:02
@fanquake fanquake merged commit 7c248b9 into bitcoin:master Jan 5, 2024
@maflcko maflcko deleted the 2312-doc20- branch January 5, 2024 15:48
@bitcoin bitcoin locked and limited conversation to collaborators Jan 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants