Skip to content

Conversation

BrandonOdiwuor
Copy link
Contributor

Fixes #28898

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 23, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Conflicts

No conflicts as of last run.

@maflcko
Copy link
Member

maflcko commented Nov 23, 2023

Could add tests for:

  • Tx in mempool
  • Watchonly wallet
  • ...

?

@fjahr
Copy link
Contributor

fjahr commented Nov 23, 2023

I think I would prefer the other option @maflcko suggested in the issue, i.e. adding a check flag to getbalances.

Add the option to getbalances by scanning the utxo set
@BrandonOdiwuor BrandonOdiwuor changed the title wallet: Add checkbalance RPC wallet: Add scan_utxo option to getbalances RPC Nov 28, 2023
@luke-jr
Copy link
Member

luke-jr commented Dec 5, 2023

getbalances seems like the wrong place for this?

@maflcko
Copy link
Member

maflcko commented Jul 15, 2024

Are you still working on this? Seems stale for more than half a year, at least.

@maflcko
Copy link
Member

maflcko commented Oct 1, 2024

Closing due to inactivity for almost a year

@maflcko maflcko closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wallet RPC to double-check the calculated balance
5 participants