Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 13, 2023

Update to the latest signapple, which includes achow101/signapple#13.
Drop python-macholib and python-altgraph.

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 13, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK Sjors
Concept ACK hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

@hebasto
Copy link
Member

hebasto commented Nov 13, 2023

Concept ACK.

@fanquake fanquake force-pushed the signapple_drop_macho_altgraph branch from cafdea8 to c97976c Compare November 13, 2023 13:42
@fanquake fanquake changed the title [WIP] guix: update signapple (drop macho & altgraph) guix: update signapple (drop macho & altgraph) Nov 13, 2023
Which includes achow101/signapple#13.
We can drop macholib (and altgraph) as deps.
@DrahtBot
Copy link
Contributor

🐙 This pull request conflicts with the target branch and needs rebase.

@fanquake fanquake force-pushed the signapple_drop_macho_altgraph branch from c97976c to f718a74 Compare November 13, 2023 16:44
@fanquake fanquake marked this pull request as ready for review November 13, 2023 16:45
@fanquake
Copy link
Member Author

Guix Build (aarch64):

7ea71c9d553c8afaa6c1f8ba72b643783910a972faabd6712f85020dbe8dbdae  guix-build-f718a74b124c/output/arm64-apple-darwin/SHA256SUMS.part
3263327cbd4ee22c21256410da377b38399d07f163a6d1c6c266aa1f9024de64  guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin-unsigned.tar.gz
dc639d8aff10827c0e1a24e4edf16425cf08d443948659ecdb76bb9d2bcae90e  guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin-unsigned.zip
8331286bb3319ca0df99f87334df0c61201da259e7b9bdcad8749d6009e516ee  guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin.tar.gz
fe79c08c27df3e03775325efb68c1f15f2bce7115c0821a8bf24561f4fa2d001  guix-build-f718a74b124c/output/dist-archive/bitcoin-f718a74b124c.tar.gz
455b3820fc5049fbc52ef247ddadf30253f29e75f635fd99ad08e64b93ea51ce  guix-build-f718a74b124c/output/x86_64-apple-darwin/SHA256SUMS.part
25d2c457c0e25ec1e34a76572b743a623647cf55d848535cb3e47a9414c9af0b  guix-build-f718a74b124c/output/x86_64-apple-darwin/bitcoin-f718a74b124c-x86_64-apple-darwin-unsigned.tar.gz
dc7efa7fe1745dbc1ebc49538d61c125ee8a6840317c70ee5e55bb25ef3365c9  guix-build-f718a74b124c/output/x86_64-apple-darwin/bitcoin-f718a74b124c-x86_64-apple-darwin-unsigned.zip
46fbe3ee968293c395337346ffb9374a786f72347c042ddcea826b1b01feb9d2  guix-build-f718a74b124c/output/x86_64-apple-darwin/bitcoin-f718a74b124c-x86_64-apple-darwin.tar.gz

@DrahtBot
Copy link
Contributor

Guix builds (on x86_64)

File commit 5800c55
(master)
commit 7f27967
(master and this pull)
SHA256SUMS.part 6bd90b9df84e04d8... 9b4d77a45c50cfa1...
*-aarch64-linux-gnu-debug.tar.gz 4b79da8e08fb0b31... 0839abeb365a8a12...
*-aarch64-linux-gnu.tar.gz 8c9e70abfd2879c4... a95b5018e6466459...
*-arm-linux-gnueabihf-debug.tar.gz 1f042a3613741406... 8e1abb5538b2cc56...
*-arm-linux-gnueabihf.tar.gz 6571a4b5735ab70e... 08d7f5a67510e826...
*-arm64-apple-darwin-unsigned.tar.gz 3fa3944ead0b745e... 589e1f9b6273e751...
*-arm64-apple-darwin-unsigned.zip 0a76c6b9f25dd80d... ff75817c719ea360...
*-arm64-apple-darwin.tar.gz 0b5e2d7a3ba6fc2d... 5006b44741bfeb0f...
*-powerpc64-linux-gnu-debug.tar.gz cca22ba8219ef0d8... 07d18a888634fcf0...
*-powerpc64-linux-gnu.tar.gz 2c5fcba31faed9f9... 03fb4c3f55928108...
*-powerpc64le-linux-gnu-debug.tar.gz 585016cec10a909d... e076fe35dfc965e2...
*-powerpc64le-linux-gnu.tar.gz 69af5870f662d399... e25d800d173d0041...
*-riscv64-linux-gnu-debug.tar.gz a32ea80cc01ed149... df90775d8a8b5c70...
*-riscv64-linux-gnu.tar.gz 6094abe347cbfea0... 172b9a34335073c8...
*-x86_64-apple-darwin-unsigned.tar.gz c6bf3593d8834575... 97cdd204fd14aad3...
*-x86_64-apple-darwin-unsigned.zip 3b48d057ee920021... fb6e608523ba332f...
*-x86_64-apple-darwin.tar.gz 0ea8d1c7516647ed... 4171689a64430f06...
*-x86_64-linux-gnu-debug.tar.gz c9b3c2d1f9f36f41... cd33c22ae2f7acdf...
*-x86_64-linux-gnu.tar.gz ba597239d06c8e52... 71314a7dbcd1e9bf...
*.tar.gz 2b84f5a633c304e7... 57f5484c313a14e3...
guix_build.log 0b55a3e85e4d68f8... 85cdd01736a1ee5f...
guix_build.log.diff a515c606c5e0e9c6...

@Sjors
Copy link
Member

Sjors commented Nov 14, 2023

ACK f718a74

Guix hashes for 'x86_64-apple-darwinandarm64-apple-darwin' (generated on x86_64 linux):

7ea71c9d553c8afaa6c1f8ba72b643783910a972faabd6712f85020dbe8dbdae  guix-build-f718a74b124c/output/arm64-apple-darwin/SHA256SUMS.part
3263327cbd4ee22c21256410da377b38399d07f163a6d1c6c266aa1f9024de64  guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin-unsigned.tar.gz
dc639d8aff10827c0e1a24e4edf16425cf08d443948659ecdb76bb9d2bcae90e  guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin-unsigned.zip
8331286bb3319ca0df99f87334df0c61201da259e7b9bdcad8749d6009e516ee  guix-build-f718a74b124c/output/arm64-apple-darwin/bitcoin-f718a74b124c-arm64-apple-darwin.tar.gz
fe79c08c27df3e03775325efb68c1f15f2bce7115c0821a8bf24561f4fa2d001  guix-build-f718a74b124c/output/dist-archive/bitcoin-f718a74b124c.tar.gz
455b3820fc5049fbc52ef247ddadf30253f29e75f635fd99ad08e64b93ea51ce  guix-build-f718a74b124c/output/x86_64-apple-darwin/SHA256SUMS.part
25d2c457c0e25ec1e34a76572b743a623647cf55d848535cb3e47a9414c9af0b  guix-build-f718a74b124c/output/x86_64-apple-darwin/bitcoin-f718a74b124c-x86_64-apple-darwin-unsigned.tar.gz
dc7efa7fe1745dbc1ebc49538d61c125ee8a6840317c70ee5e55bb25ef3365c9  guix-build-f718a74b124c/output/x86_64-apple-darwin/bitcoin-f718a74b124c-x86_64-apple-darwin-unsigned.zip
46fbe3ee968293c395337346ffb9374a786f72347c042ddcea826b1b01feb9d2  guix-build-f718a74b124c/output/x86_64-apple-darwin/bitcoin-f718a74b124c-x86_64-apple-darwin.tar.gz

@DrahtBot DrahtBot requested a review from hebasto November 14, 2023 09:36
@fanquake fanquake merged commit 0aa014d into bitcoin:master Nov 15, 2023
@fanquake fanquake deleted the signapple_drop_macho_altgraph branch November 15, 2023 15:18
@bitcoin bitcoin locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants