Skip to content

Conversation

xslidian
Copy link

Several accuracy and punctuation improvements. :D

sipa and others added 5 commits May 22, 2011 17:12
When rescanning, if the scanned transaction is already in the wallet, it
is skipped. However, if someone sends a transaction, does not wait for
confirmation, switches wallets, waits for a block that contains his original
transaction, and switches wallets again, a rescan will leave his wallet
transaction (which has no merkle branch, so no confirmations) untouched.
With the separation of CENT and MIN_TX_FEE, it is now reasonable
to create change outputs between 0.01 and 0.0005, as these are
spendable according to the policy, even though they require a fee
to be paid.

Also, when enough fee was already present, everything can go into
a change output, without further increasing the fee.
For instance any nBits compressed value from 0x1a44b800 thru
0x1a44b9ff will show as difficulty 244139.4816. This patch will
more accurately convert the nBits compressed values to the double
difficulty.

This will display any of the recent difficulty levels slightly
differently though. Early difficulties and testnet difficulties are
not large enough to trigger this bug.

None of the actual targets or compressed targets are changed, only
the conversion to the floating point difficulty is changed and afaik
it is only ever displayed, never converted back so the patch does not
effect the target calculations, binary files, databases nor the binary
protocol.
@xslidian xslidian closed this May 28, 2011
@xslidian xslidian reopened this May 28, 2011
@jgarzik
Copy link
Contributor

jgarzik commented Jun 7, 2011

Can you please do two things?

  1. Resubmit on top of current bitcoin
  2. Do not include *.mo files. We will rebuild those.

@xslidian xslidian closed this Jun 9, 2011
zathras-crypto pushed a commit to zathras-crypto/omnicore that referenced this pull request Feb 3, 2015
Add support for TX70 to populateRPCTransactionObject
ptschip pushed a commit to ptschip/bitcoin that referenced this pull request Feb 9, 2017
CodeShark pushed a commit to CodeShark/bitcoin that referenced this pull request May 4, 2017
Litecoin: Fix p2p-compactblocks.py test hang
0xartem pushed a commit to Crowndev/crown-core that referenced this pull request Feb 14, 2019
lbrynaut pushed a commit to lbrynaut/bitcoin that referenced this pull request Sep 17, 2019
* added test for claimname RPC
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Oct 16, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants