Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Jun 14, 2023

@fanquake fanquake added this to the 25.1 milestone Jun 14, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented Jun 14, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK stickies-v

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f74ffc0

@maflcko
Copy link
Member

maflcko commented Jun 14, 2023

May also need 27777 and 27844 ?

MarcoFalke and others added 6 commits June 15, 2023 10:38
This should avoid a race where the kill is not done when spinning up the
new container. podman stop waits 10 seconds by default.

Github-Pull: bitcoin#27844
Rebased-From: faaa627
Tee `arm_container` does not support 32-bit mode anymore.
See: bitcoin#27879

Github-Pull: bitcoin#27886
Rebased-From: 016fe6d
@fanquake
Copy link
Member Author

May also need 27777 and 27844 ?

Pulled them in.

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6233049

For completeness, would also mention that it backports #27562?

@fanquake
Copy link
Member Author

For completeness, would also mention that it backports #27562?

Added to the PR description.

@fanquake fanquake merged commit 642b5dd into bitcoin:25.x Jun 16, 2023
@fanquake fanquake deleted the 25_x_bacports branch June 16, 2023 09:23
@bitcoin bitcoin locked and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants