Skip to content

Conversation

fanquake
Copy link
Member

Backports #27724 to 25.x.

Disable boost multi index safe mode by default when configuring with
--enable-debug.

This option can cause transactions to take a long time to be accepted
into the mempool under certain conditions; iterator destruction takes
O(n) time vs O(1) as they are stored in a singly linked list. See
27586 for more information.

Re-enable it on the CI builds which previously had it enabled.

Re-enable it on the msan fuzz target so that we have fuzz tasks testing
with it enabeld and disabled in this repo.

Github-Pull: bitcoin#27724
Rebased-From: 59c8944
@fanquake fanquake added this to the 25.1 milestone May 29, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented May 29, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK stickies-v

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 9dc5848

Identical to the changes in 59c8944 (#27724), except two changes (1, 2) to the CI setup which I think can safely be ignored.

@fanquake fanquake merged commit cda3fe2 into bitcoin:25.x Jun 2, 2023
@fanquake fanquake deleted the 25_x_backport_27724 branch June 2, 2023 09:11
@bitcoin bitcoin locked and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants