Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented May 10, 2023

@fanquake fanquake added this to the 25.0 milestone May 10, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented May 10, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake fanquake changed the title [25.x] Backports for rc2 [25.0] Backports for rc2 May 11, 2023
ajtowns and others added 3 commits May 11, 2023 14:29
We use CompareDepthAndScore to choose an order of txs to inv. Rather
than sorting txs that have been evicted from the mempool at the end
of the list, sort them at the beginning so they are removed from
the queue immediately.

Github-Pull: bitcoin#27610
Rebased-From: 228e920
If transactions are being added to the mempool at a rate faster than 7tx/s
(INVENTORY_BROADCAST_PER_SECOND) then peers' inventory_to_send queue can
become relatively large. If this happens, increase the number of txids
we include in an INV message (normally capped at 35) by 5 for each 1000
txids in the queue.

This will tend to clear a temporary excess out reasonably quickly; an
excess of 4000 invs to send will be cleared down to 1000 in about 30
minutes, while an excess of 20000 invs would be cleared down to 1000 in
about 60 minutes.

Github-Pull: bitcoin#27610
Rebased-From: 5b34060
@achow101
Copy link
Member

ACK 7ef71e3

@fanquake
Copy link
Member Author

Added a version bump for 25.0rc2.

@achow101
Copy link
Member

ACK 49a2d66

@fanquake fanquake merged commit 8996da6 into bitcoin:25.x May 11, 2023
@fanquake fanquake deleted the backports_25_0_rc2 branch May 11, 2023 18:16
@bitcoin bitcoin locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants