Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Apr 18, 2023

rc1 (tagged > a month ago) was mostly a no-op, due to lack of binaries. While some are up now, albeit at the wrong URL, there seems no point continuing the rc1 cycle, when we already have additional changes backported (#27474), and we've also received no bug reports/feedback from anyone who did test.

So bump the version, and cut an rc2.

@fanquake fanquake added this to the 24.1 milestone Apr 18, 2023
@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 18, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK hebasto, achow101, gruve-p

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 03a16a1, I have reviewed the code and it looks OK.

there seems no point continuing the rc1 cycle, when we already have additional changes backported

Agree.

@achow101
Copy link
Member

ACK 03a16a1

@gruve-p
Copy link
Contributor

gruve-p commented Apr 19, 2023

ACK 03a16a1

@fanquake fanquake merged commit 36c15d7 into bitcoin:24.x Apr 19, 2023
@fanquake fanquake deleted the 24_1_rc2_bump branch April 19, 2023 08:21
@bitcoin bitcoin deleted a comment from Raen111 Mar 5, 2024
@bitcoin bitcoin locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants