refactor: extract CCheckQueue's data handling into a separate container "Bag" #27331
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This introduces a simple container where elements can be added and removed. The order of element removal is not specified and might change in future due to e.g. optimizations. The logic for that container is purely copied from CCheckQueue's current implementation of the queue.
This simplfies CCheckQueue's Loop by using the new Bag container.
|
ACK 6a9c6ea |
|
I didn't dive too deeply into this yet but it's a bit sad that we can not remove more code due to this, that would certainly make it a more interesting change. Do you already have other places in mind where we could use this? You also mention the order of elements, but it's unclear why that is important. This hasn't changed right? Or is this just about the naming choice? I can't really make sense of the CI failure. Could you do a rebase? Since this is a fairly old change it might be some hidden merge conflict. |
|
🤔 There hasn't been much activity lately and the CI seems to be failing. If no one reviewed the current pull request by commit hash, a rebase can be considered. While the CI failure may be a false positive, the CI hasn't been running for some time, so there may be a real issue hiding as well. A rebase triggers the latest CI and makes sure that no silent merge conflicts have snuck in. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
This PR does not seem to have attracted much attention from reviewers. As such, it does not seem important enough right now to keep it sitting idle in the list of open PRs. Closing due to lack of interest. |
CCheckQueuehas stored its work items in aqueue, but made no guarantee about the order of elements in that container. This PR extracts that data storage handling into a separate container classBag. This is pure refactoring, the result should have a better separation of concerns, adds tests for the new container, and makes it now easier to separately test and optimize the container.