Skip to content

doc: recommend brew install python@3.7 (minimum version) #27130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: recommend brew install python@3.7 (minimum version) #27130

wants to merge 1 commit into from

Conversation

RandyMcMillan
Copy link
Contributor

No description provided.

@DrahtBot
Copy link
Contributor

DrahtBot commented Feb 20, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
Concept NACK brunoerg, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake
Copy link
Member

NACK. There's no need to install an old version of Python.

@fanquake fanquake changed the title build-osx.md: recommend brew install python@3.7 (minimum version) doc: recommend brew install python@3.7 (minimum version) Feb 20, 2023
@DrahtBot DrahtBot added the Docs label Feb 20, 2023
brunoerg
brunoerg reviewed Feb 20, 2023
View reviewed changes
Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

For me it doesn't make sense to suggest to install the minimum version. I prefer to have users with the most recent one, not the minimum one.

@RandyMcMillan RandyMcMillan force-pushed the 1676913327/0fe225e37/9c47eb450-build-osx-python3.7-minimum branch from 4f4eca6 to b2f2951 Compare February 20, 2023 17:41
@RandyMcMillan
Copy link
Contributor Author

updated :

brew install python@3

https://github.com/bitcoin/bitcoin/blob/b2f2951e51b0be370041ec63527bad8fc0dab3ad/doc/build-osx.md#test-suite-dependencies

@fanquake
Copy link
Member

NACK - python and python@3 are the same thing (both aliases for python 3.11, which is the current latest version). We can leave these docs as-is, and/or worry about changing them when Python 4 is (never) released. Thanks.

@fanquake fanquake closed this Feb 20, 2023
@RandyMcMillan
Copy link
Contributor Author

To maintain consistency across macOS x86 and Arm64 maybe the minimum python3 version should be python@3.8

Screen Shot 2023-02-20 at 1 00 41 PM

ref: #26226

@RandyMcMillan RandyMcMillan mentioned this pull request Feb 20, 2023
Merged
@Sjors
Copy link
Member

Sjors commented Feb 21, 2023 •
edited
Loading

@RandyMcMillan maybe make a separate issue about M1 not supporting Python 3.7 (I don't have one, so can't confirm). It's just one of many operating systems we support, but a lot of devs use it so it seems worth looking into.

@fanquake
Copy link
Member

Thanks, but there is no need to make an issue. There is nothing here that needs to be solved.

@bitcoin bitcoin locked and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@brunoerg brunoerg brunoerg left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RandyMcMillan @DrahtBot @fanquake @Sjors @brunoerg