refactor: Continue moving application data from CNode to Peer #26621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
58269b5 to
8337193
Compare
8337193 to
f549881
Compare
maflcko
reviewed
Dec 5, 2022
f549881 to
8209e93
Compare
This was referenced Dec 6, 2022
|
What's the goal of this refactor? Seems like the "refactor moratorium" should apply? |
This is continuing the work outlined here: #19398 |
This was referenced Dec 16, 2022
4 tasks
Merged
Most of the stats in CNodeStateStats are now taken from the Peer object.
Rename the struct to PeerStats.
-BEGIN VERIFY SCRIPT-
ren() { sed -i "s:\<$1\>:$2:g" $(git grep -l "\<$1\>" ./src ./test); }
ren CNodeStateStats PeerStats
ren GetNodeStateStats GetPeerStats
ren nodeStateStats m_peer_stats
ren statestats peer_stats
ren fNodeStateStatsAvailable m_peer_stats_available
ren fStateStats peer_stats_available
-END VERIFY SCRIPT-
Also rename to m_clean_subversion. Since the subversion is now contained in the Peer object, it may not be available in `getpeerinfo` while the peer connection is being torn down. Update the rpc help text to mark the field optional and update the tests to tolerate the field being absent.
Handle version nonces entirely within net_processing.
58220e2 to
a840290
Compare
This was referenced Sep 11, 2023
|
🐙 This pull request conflicts with the target branch and needs rebase. |
This was referenced Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up a subset of changes from #24970 and additionally moves
m_bip152_highbandwith{to,from},nTimeOffset,nVersion,m_greates_common_version.