Skip to content

[22.x] Bump version to 22.1rc2 & add release notes #26547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 23, 2022
Merged

[22.x] Bump version to 22.1rc2 & add release notes #26547

merged 3 commits into from
Nov 23, 2022

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 21, 2022 •
edited
Loading

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 21, 2022 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK stickies-v, jarolrod
Concept ACK MarcoFalke
Stale ACK hebasto

@hebasto
Copy link
Member

hebasto commented Nov 22, 2022

There are no translation updates since #26431.

@fanquake fanquake marked this pull request as ready for review November 22, 2022 09:40
hebasto
hebasto approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 72c3eaf

hebasto
hebasto approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK 4bbab04

stickies-v
stickies-v reviewed Nov 22, 2022
View reviewed changes
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that as outlined in https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md:

  • the manpages were updated correctly
  • the rc version in configure.ac was updated correctly
  • the changes since v22.0 match with what is listed in release-notes.md, and found 1 missing PR that I outlined in a comment to this review

I did not verify the translations.

stickies-v
stickies-v approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9bd628

@stickies-v stickies-v mentioned this pull request Nov 22, 2022
Closed
jarolrod
jarolrod reviewed Nov 22, 2022
View reviewed changes
Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9bd628

@maflcko
Copy link
Member

maflcko commented Nov 23, 2022

Thanks, Concept ACK

@fanquake fanquake merged commit 9182b2f into bitcoin:22.x Nov 23, 2022
@fanquake fanquake deleted the prep_22.1rc2 branch November 23, 2022 17:33
@fanquake fanquake added this to the 22.1 milestone Nov 29, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

+2 more reviewers

@jarolrod jarolrod jarolrod left review comments

@stickies-v stickies-v stickies-v approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
22.1
Development

Successfully merging this pull request may close these issues.
6 participants
@fanquake @DrahtBot @hebasto @maflcko @jarolrod @stickies-v