Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Nov 17, 2022

MacOS 13 sends a window focus change notification after the main
window has been destroyed but before the QTApplication has been
destroyed. This results in the menu bar receiving a notification
despite it no longer existing. The solution is to pass the main
window as context when subscribing to the notifications. Qt
automatically unsubscribes to notifications if the sender OR
context is destroyed.

Github-Pull: bitcoin-core/gui#680
Rebased-From: 8a5014c
@hebasto hebasto added this to the 24.1 milestone Nov 17, 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 17, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Count Reviewers
ACK 1 jarolrod

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 39af5f2

would be nice to have in 24 👉👈

@fanquake fanquake merged commit c1061be into bitcoin:24.x Nov 18, 2022
@hebasto hebasto deleted the 221117-24.1-gui-bp branch November 19, 2022 15:51
@fanquake fanquake modified the milestones: 24.1, 24.0.1 Nov 29, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants