WIP: Fix coinstatsindex overflow issue #26426
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| @@ -877,7 +877,7 @@ static RPCHelpMan gettxoutsetinfo() | |||
| {RPCResult::Type::NUM, "transactions", /*optional=*/true, "The number of transactions with unspent outputs (not available when coinstatsindex is used)"}, | |||
| {RPCResult::Type::NUM, "disk_size", /*optional=*/true, "The estimated size of the chainstate on disk (not available when coinstatsindex is used)"}, | |||
| {RPCResult::Type::STR_AMOUNT, "total_amount", "The total amount of coins in the UTXO set"}, | |||
| {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The total amount of coins permanently excluded from the UTXO set (only available if coinstatsindex is used)"}, | |||
| {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The amount of coins permanently excluded from the UTXO set from this block onwards (only available if coinstatsindex is used)"}, | |||
There was a problem hiding this comment.
"onwards" seems unlikely to be correct?
| @@ -877,7 +877,7 @@ static RPCHelpMan gettxoutsetinfo() | |||
| {RPCResult::Type::NUM, "transactions", /*optional=*/true, "The number of transactions with unspent outputs (not available when coinstatsindex is used)"}, | |||
| {RPCResult::Type::NUM, "disk_size", /*optional=*/true, "The estimated size of the chainstate on disk (not available when coinstatsindex is used)"}, | |||
| {RPCResult::Type::STR_AMOUNT, "total_amount", "The total amount of coins in the UTXO set"}, | |||
| {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The total amount of coins permanently excluded from the UTXO set (only available if coinstatsindex is used)"}, | |||
| {RPCResult::Type::STR_AMOUNT, "total_unspendable_amount", /*optional=*/true, "The amount of coins permanently excluded from the UTXO set from this block onwards (only available if coinstatsindex is used)"}, | |||
There was a problem hiding this comment.
Should rename the field if it's a different value
|
🐙 This pull request conflicts with the target branch and needs rebase. |
|
There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
1 similar comment
|
⌛ There hasn't been much activity lately and the patch still needs rebase. What is the status here?
|
|
Closing for now due to inactivity for 1.5 years. ##26362 remains open and can be used for discussion. This change can be reopened or recreated as a new pull request. |
|
#30469 continues the work here |
Closes #26362
This changes cumulative values in coinstatsindex to be per-block instead. This is still work in progress and needs further testing and cleanup. Please refer to #26362 for conceptual discussion for now.