Skip to content

[24.x] p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started #26382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2022
Merged

[24.x] p2p: Handle IsContinuationOfLowWorkHeadersSync return value correctly when new headers sync is started #26382

merged 1 commit into from
Oct 27, 2022

Conversation

glozow
Copy link
Member

@glozow glozow commented Oct 24, 2022

Backport of #26355.

@dergoegge @glozow
[net processing] Handle IsContinuationOfLowWorkHeadersSync return val…
e23def8 
…ue correctly when new headers sync is started
@glozow glozow mentioned this pull request Oct 24, 2022
Merged
@maflcko maflcko added this to the 24.0 milestone Oct 24, 2022
@dergoegge
Copy link
Member

ACK e23def8

stickies-v
stickies-v approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@stickies-v stickies-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e23def8

Changes are identical to #26355, and they're based on the same PeerManagerImpl::TryLowWorkHeadersSync() function - no changes there either.

@glozow glozow merged commit d22cc74 into bitcoin:24.x Oct 27, 2022
@luke-jr
Copy link
Member

luke-jr commented Oct 28, 2022

@glozow In the future, if you're not merging the exact same commit, please add the usual "Github-Pull" and "Rebased-From" fields to the commit messages.

@glozow
Copy link
Member Author

glozow commented Oct 28, 2022

@luke-jr will do, thanks

@glozow glozow deleted the 2022-10-backport-26355 branch October 28, 2022 09:58
@bitcoin bitcoin locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@stickies-v stickies-v stickies-v approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Backport
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@glozow @dergoegge @luke-jr @stickies-v @maflcko