script: create V1SigVersion for functions which should only accept taproot/tapscript #26101
Conversation
|
ping @sipa . Curious if you dislike this as it ties these functions to this subset of sigversions, though it could easily be ranamed/expanded later to mean "non-v0" if necessary. |
|
Whoops, apparently I missed a few cases. Converting to draft for now. Concept ACKs/NACKs welcome. |
Some functions only accept a subset of script versions, leaving them with undefined behavior when called with v0 scripts. Instead, define a type that is a subset of ScriptVersion and use it when applicable.
58c08d7 to
0ba2daa
Compare
|
Fixed up now. Ironically this doesn't actually eliminate the warning as I'd hoped. I will leave this open in case anyone finds it interesting, but no need to think of it in terms of #25972 (comment). |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
🐙 This pull request conflicts with the target branch and needs rebase. |
This is intended to be a safer way for functions to accept only a subset of sigversion values.
It's intended to solve the uninitialized value warning seen here: #25972 (comment)
Now that all possible values in the
enum classare tested, there's no need for a default case and thus the compiler should be able to deduce that there's no way for this value to be used uninitialized.Sadly it's not possible to do any type of inheritance with an
enum class, so instead it's faked by usingstd::underlying_type_t<SigVersion>, which should ensure that it's in sync withSigVersioneven if it changes in the future.Imo this is safe enough that there's no need for a default case as suggested here: #25972 (comment) , but that's up for discussion here.
The second commit is simply a cleanup that removes the need to pass a sigversion to EvalChecksigTapscript because it's only intended to ever be used with... tapscript.