@mzumsande has suggested having separate -onlynet options for inbound and outbound. I think that's a valid option as well and if reviewers prefer that approach I can draft that one as well.

I think this can and should be resolved in a simpler way by removing IsReachable() from AddLocal() and IsPeerAddrLocalGood().

The new option -allowinbound would be difficult to explain to users. By its name, I would guess that -allowinbound=0 should do the same as -listen=0.

I like the onlynet inbound/outbound. There is consistently confusion about the network settings and how they interact (and bugs found), and I think this would really clear things up. Also, this would translate easily to GUI settings.

What would -onlynet inbound do? Is that not the same as omitting the network from -bind=?

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #25775 (docs: remove non-signaling mentions of BIP125 by glozow)
• #24170 (p2p, rpc: Manual block-relay-only connections with addnode by mzumsande)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Maybe I don't understand the purpose of the PR, but I thought it would make changes such as:
-cjdnsreachable -> -allowinbound=cjdns
-onlynet=cjdns -> '-allowoutbound=cjdns

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

There hasn't been much activity lately and the patch still needs rebase. What is the status here?

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

Closing this for now as I currently don't have time to continue with this. I hope I can revisit it in the future.