Skip to content

Conversation

furszy
Copy link
Member

@furszy furszy commented May 25, 2022

Fixing #25083 (comment).

Without the fee rate, 'GroupOutputs' will crash at group insertion time OutputGroup::Insert because now output.GetEffectiveValue() asserts that the value exists.

Otherwise, 'GroupOutputs' will crash at group insertion time (output.GetEffectiveValue() asserts that the value exists).
@furszy furszy force-pushed the 2022_fuzz_solve_coinselection branch from c2d3733 to c97e961 Compare May 25, 2022 17:08
@achow101
Copy link
Member

ACK c97e961

Copy link
Contributor

@brunoerg brunoerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c97e961

@ishaanam
Copy link
Contributor

ACK c97e961

1 similar comment
@murchandamus
Copy link
Contributor

ACK c97e961

@achow101 achow101 merged commit 192d639 into bitcoin:master May 25, 2022
@bitcoin bitcoin locked and limited conversation to collaborators May 25, 2023
@furszy furszy deleted the 2022_fuzz_solve_coinselection branch May 27, 2023 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants