Skip to content

Conversation

BradleyC
Copy link

Add txindex to miscellaneous config options.

As a developer migrating from Ethereum to BTC development, it's incredibly useful to see this option in the default config rather than discovering the option later and having to reindex, reboot development stack, etc.

Add txindex to miscellaneous config options.
@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #22235 (script: add script to generate example bitcoin.conf by josibake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@josibake
Copy link
Member

hi @BradleyC , I've proposed #22235 as a "once and for all" solution to this problem. The idea is to generate a config file from the bitcoind help output so that every config option is documented and kept up-to-date with each Bitcoin Core release. Would love to have your input on the PR

@BradleyC
Copy link
Author

Issue #22235 addresses this use case much more elegantly, when that PR gets merged this would become irrelevant.

updated text for clarity
@@ -156,6 +156,10 @@
# Maintain coinstats index used by the gettxoutsetinfo RPC (default: 0).
#coinstatsindex=1

# Maintains an index of all transactions that have ever happened, which you can query using the remote procedure
Copy link
Member

@jonatack jonatack Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If you are still maintaining this proposal, you would need to remove the trailing space here for the CI linter task to pass. You can verify your change locally by running test/lint/lint-whitespace.py.

  • Maybe can be shortened and state the default, similar to the existing coinstats entry:

-# Maintains an index of all transactions that have ever happened, which you can query using the remote procedure 
-# call (RPC) method `getrawtransaction` or the RESTful API call `get-tx`.
+# Maintain transaction index used by the getrawtransaction RPC (default: 0).
 #txindex=1

@fanquake
Copy link
Member

fanquake commented May 4, 2022

Closing this now that #22235 has been merged.

@fanquake fanquake closed this May 4, 2022
@laanwj
Copy link
Member

laanwj commented May 4, 2022

Closing as #22235 made it in. Please make any changes to help text in the option declarations in init.cpp etc.

@bitcoin bitcoin locked and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants