-
Notifications
You must be signed in to change notification settings - Fork 37.8k
Update bitcoin.conf #24969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bitcoin.conf #24969
Conversation
Add txindex to miscellaneous config options.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Issue #22235 addresses this use case much more elegantly, when that PR gets merged this would become irrelevant. |
updated text for clarity
@@ -156,6 +156,10 @@ | |||
# Maintain coinstats index used by the gettxoutsetinfo RPC (default: 0). | |||
#coinstatsindex=1 | |||
|
|||
# Maintains an index of all transactions that have ever happened, which you can query using the remote procedure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
If you are still maintaining this proposal, you would need to remove the trailing space here for the CI linter task to pass. You can verify your change locally by running
test/lint/lint-whitespace.py
. -
Maybe can be shortened and state the default, similar to the existing coinstats entry:
-# Maintains an index of all transactions that have ever happened, which you can query using the remote procedure
-# call (RPC) method `getrawtransaction` or the RESTful API call `get-tx`.
+# Maintain transaction index used by the getrawtransaction RPC (default: 0).
#txindex=1
Closing this now that #22235 has been merged. |
Closing as #22235 made it in. Please make any changes to help text in the option declarations in |
Add txindex to miscellaneous config options.
As a developer migrating from Ethereum to BTC development, it's incredibly useful to see this option in the default config rather than discovering the option later and having to reindex, reboot development stack, etc.