tests: commit-script-check.sh - use gsed if exists #24159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoerg
reviewed
Jan 26, 2022
w0xlt
approved these changes
Jan 26, 2022
|
merged @brunoerg commit - will squash after CI pass. |
On macOS the default sed utility is not GNU sed, therefore the commit-script-check.sh script fails. This commit adds a check for gsed and uses it if it exists. Co-authored-by: Bruno Garcia <brunoely.gc@gmail.com>
c56df55 to
ca3d686
Compare
|
Concept ACK |
|
I know I'm repeating myself but I really prefer more complex scripts to be Python to avoid these kind of platform-specific contortions around different shells and basic utilities. Lacking that, Concept ACK. |
|
Going to optimistically close this for now, given we are just going to port this to Python (#24783). I'm sure we can come up with a solution that doesn't require sed, or gsed or bash, or any other nonsense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS the default sed utility is not GNU sed,
therefore the commit-script-check.sh script fails.
This commit adds a check for gsed and uses it if it exists.