Skip to content

Conversation

TheBlueMatt
Copy link
Contributor

Sorry for all the pull request mess the last three times. In any case, this works on all three platforms and includes WXUI switch for UPnP enabling/disabling on the fly. See http://www.bitcoin.org/smf/index.php?topic=4392.msg64230#msg64230 for discussion.

@jgarzik
Copy link
Contributor

jgarzik commented Mar 29, 2011

Comments:

  1. The community poll and I seem to agree, upnp should be disabled by default (USE_UPNP==0)

  2. Rather than all those ifdefs, it would be nice to define 'static const fHaveUPNP' and test that where possible. The compiler will optimize out code that is known never to be called.

…d at build time(statically linked).

Thanks joepie91 for the translation of the new copyright notices into Dutch.
Thanks sipa for the translation of the new copyright notices into French.
Thanks megu for the translation of the new copyright notices into Spanish.
Thanks justmoon/Blitzboom for the translation of the new copyright notices into German.
Thanks Joozero for the translation of the new copyright notices into Italian.
Remaining translations were provided by Google Translate.
@TheBlueMatt
Copy link
Contributor Author

Although I disagree, UPnP is now set to off by default in all makefiles.
fHaveUPnP is used in many places now, however #ifdef USE_UPNP was still used in several.

@gavinandresen gavinandresen merged commit 8bb5edc into bitcoin:master Apr 12, 2011
glv2 referenced this pull request in glv2/peercoin Nov 4, 2014
Use the right icon for immature minting transactions.
sipa added a commit to sipa/bitcoin that referenced this pull request Dec 4, 2014
b0210a9 Merge pull request bitcoin#135
ee3eb4b Fix a memory leak and add a number of small tests.
4d879a3 Merge pull request bitcoin#134
d5e8362 Merge pull request #127
7b92cf6 Merge pull request bitcoin#132
0bf70a5 Merge pull request bitcoin#133
29ae131 Make scalar_add_bit test's overflow detection exact
9048def Avoid undefined shift behaviour
efb7d4b Use constant-time conditional moves instead of byte slicing
d220062 Merge pull request bitcoin#131
82f9254 Fix typo
601ca04 Merge pull request #129
35399e0 Bugfix: b is restricted, not r
c35ff1e Convert lambda splitter to pure scalar code.
cc604e9 Avoid division when decomposing scalars
ff8746d Add secp256k1_scalar_mul_shift_var
bd313f7 Merge pull request #119
276f987 Merge pull request #124
25d125e Merge pull request #126
24b3c65 Add a test case for ECDSA recomputing infinity
32600e5 Add a test for r >= order signature handling
4d4eeea Make secp256k1_fe_mul_inner use the r != property
be82e92 Require that r and b are different for field multiplication.
597128d Make num optional
659b554 Make constant initializers independent from num
0af5b47 Merge pull request #120
e2e8a36 Merge pull request #117
c76be9e Remove unused num functions
4285a98 Move lambda-splitting code to scalar.
f24041d Switch all EC/ECDSA logic from num to scalar
6794be6 Add scalar splitting functions
d1502eb Add secp256k1_scalar_inverse_var which delegates to GMP
b5c9ee7 Make test_point_times_order test meaningful again
0b73059 Switch wnaf splitting from num-based to scalar-based
1e6c77c Generalize secp256k1_scalar_get_bits
5213207 Add secp256k1_scalar_add_bit
3c0ae43 Merge pull request #122
6e05287 Do signature recovery/verification with 4 possible recid case
e3d692f Explain why no y=0 check is necessary for doubling
f7dc1c6 Optimize doubling: secp256k1 has no y=0 point
666d3b5 Merge pull request #121
2a54f9b Correct typo in comment
9d64145 Merge pull request #114
99f0728 Fix secp256k1_num_set_bin handling of 0
d907ebc Add bounds checking to field element setters
bb2cd94 Merge pull request #116
665775b Don't split the g factor when not using endomorphism
9431d6b Merge pull request #115
e2274c5 build: osx: attempt to work with homebrew keg-only packages

git-subtree-dir: src/secp256k1
git-subtree-split: b0210a9
dexX7 added a commit to dexX7/bitcoin that referenced this pull request Jul 15, 2015
012653e Report progress based on transactions, report estimated time remaining (dexX7)
rebroad pushed a commit to rebroad/bitcoin that referenced this pull request Mar 16, 2016
Update release docs (bitcoin > bitcoinclassic)
rebroad pushed a commit to rebroad/bitcoin that referenced this pull request Dec 7, 2016
deadalnix pushed a commit to deadalnix/bitcoin that referenced this pull request Jan 19, 2017
9048def Avoid undefined shift behaviour (Pieter Wuille)
jgarzik added a commit to jgarzik/bitcoin that referenced this pull request Oct 12, 2017
…tional-tests

Explicitly skip broken tests so that the test runner doesn't complain…
destenson pushed a commit to destenson/bitcoin--bitcoin that referenced this pull request Nov 18, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Dec 9, 2017
[ppcoin v0.6] Tests & trivial RPC serialization fix
cryptapus added a commit to cryptapus/bitcoin that referenced this pull request Jan 31, 2019
MIP5 - GetGeometricPrevWork2 using uint256_nthRoot
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Feb 23, 2019
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants