[qt] Fixed tx-view min amount typing period on locales using comma #13278
Conversation
Fixed not being able to type a period in the transaction view "Min amount" box on locales using comma. Now you can only enter periods, but not commas.
When a comma is typed in the transaction view "Min amount" box it will be automatically translated into a period.
|
I'm trying to understand the Qt code here. If the Qt client is supposed to be culture aware when it comes to handling of the radix point, shouldn't we let the locale machinery handle it throughout to make the radix point handling consistent? (Also, very theoretically the user could be using an exotic evil locale with a radix point other than |
|
It now works like any other place an amount is entered. So it should be consistent everywhere now. And even if the user is using some weird locale it'll still allow them to type a period using the period key(or even the comma key). Before it would only let them type their locale's radix point which would not result in a valid number. |
|
Concept ACK. This also allows copy&paste. |
|
Yes. Why not. |
| Needs rebase |
|
NACK: too complex for a locale related issue. |
|
No activity in more than 2 months. Let me know when you want to work on this again and I can reopen. |
This allows the user to enter periods into the "Min amount" box in the transaction view on locales using commas. Previously only commas could be entered, which does not work.
Now when a comma is typed it will also be automatically translated into a period.