Reorganize(): remove spurious TxnAbort() #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 14, 2012
|
This does not seem to cause problems in testing, but would appreciate some additional eyes on it. |
If Reorganize() fails, then its caller, CBlock::SetBestChain(), will call TxnAbort(). Redundant TxnAbort() calls are harmless. The second will return an error return value, with no other side effects. TxnAbort() return values are generally never checked. The impact is nil.
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
* fix flag/ref order * hold cs_vNodes in ConnectNode a little bit longer * fix
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
move fastfilter from gigaperf, add unit tests
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
…ature b32e418 [Wallet] Add function CMerkleTx::IsInMainChainImmature (random-zebra) Pull request description: This introduces a little performance optimization, removing the double call to `GetDepthInMainChain` (ref: PIVX-Project#1281 (comment)). Note: in a successive PR we should review the LOCKs in this area of the wallet. ACKs for top commit: furszy: utACK b32e418 Tree-SHA512: 69e16557dd67e0450b3b9a14a3a182be39bdfcec8ef5a49ca156d9511cd9a7a532c650ed8440b147795dc3d003d10f1c8c737d0990db6365cdada2eb66997892
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Reorganize() fails, then its caller, CBlock::SetBestChain(),
will call TxnAbort().
Redundant TxnAbort() calls are harmless. The second will return an
error return value, with no other side effects. TxnAbort() return
values are generally never checked. The impact is nil.