Hide UI immediately after leaving the main loop

Hide UI immediately after leaving the main loop

* reqmgr: Remove unused blockPacer obj

* reqmgr: Don't clear CNodeRequestData before deleting it

It is all deleted further down with item.availableFrom.clear()
anyways.

* reqmgr: Explicit nullptr check

* reqmgr: rename AlreadyAskedFor -> AlreadyAskedForBlock

As it is only checking whether it already asked for a block, not
a transaction.

* reqmgr: ResetLastRequestTime -> ResetLastBlockRequestTime

As, similar to the last commit, this only concerns block requests.

* reqmgr: Fix a 0 to a nullptr

* reqmgr: Remove old, commented-out declarations

…te out of main

f578a68 Move CValidationState to consensus subdir (Fuzzbawls)
083cc4d Use AbortNode instead of state.Abort (Fuzzbawls)
ad77d3d Move consensus constants to consensus.h (Fuzzbawls)
c210d20 Move CBlockTemplate from main.h to miner.h (Fuzzbawls)
4d8b9ce Move CBlockFileInfo class from main.h to chain.h (Fuzzbawls)
668ac61 Refactor nMaxMoneyOut back to amount.h (Fuzzbawls)

Pull request description:

  This is the first part of bitcoin#1209 that moves the CBlockFileInfo and CValidationState classes (and their supporting constants) out of `main.cpp(.h)`

  @barrystyle's original commits have been further split to assist in review-ability ease.

  I left the refactor of `nMaxMoneyOut` and `CBlockTemplate` included here as they are rather straight forward, however they each now are in their own respective commits.

ACKs for top commit:
  random-zebra:
    utACK f578a68
  furszy:
    utACK f578a68

Tree-SHA512: 4433aacde02be0479d6c8ac3d6d4d725c4ed5518c82a412539e791f62b63516f042828c0407a697b4018c8f92965425f05837293a38d6da890a98bdf0e4e9dfe

…ndo.h respectively

fe2af5e Move CDiskTxPos/CBlockUndo to txdb.h/undo.h respectively (barrystyle)

Pull request description:

  This is PR is the second part of breaking up bitcoin#1209 into individual narrow-focused PRs. Original commit was cherry-picked from @barrystyle's initial pre-squashed branch (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209)

  Here `CDiskTxPos` and `CBlockUndo` are moved out of `main.h` into more appropriate files, namely `txdb.h` and `undo.h`.

ACKs for top commit:
  furszy:
    utACK fe2af5e
  random-zebra:
    utACK fe2af5e and merging...

Tree-SHA512: 57c7d55da931338b5212f412cadca639f2e1a9b90ea47749bf7e0c981af1091d2cb065cb8e1a6592db94b06085e59f6271b259b4a328ded8afcaf9d7bed089cf

…us/tx_verify.cpp

1e0bc16 Move transaction checks out to consensus/tx_verify.cpp. (barrystyle)

Pull request description:

  This is PR is the third part of breaking up bitcoin#1209 into individual narrow-focused PRs. Original commit(s) were cherry-picked from @barrystyle's initial pre-squashed branch and then re-squashed (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209)

  Input commits:
  Fuzzbawls@90950f1
  Fuzzbawls@10b7566

  ---------------

  This Moves the basic (non-zerocoin) transaction validation checks away from main.h(cpp) and into the `consensus` subdir. Code move only, no changes to functionality.

  This PR conflicts minorly with bitcoin#1319, and will need to be rebased once that PR is merged, but reviewing is possible now as the conflicts are mostly just matter-of-fact conflicts due to both PRs touching a common file.

  Relies on:
  - [x] bitcoin#1319

ACKs for top commit:
  furszy:
    utACK 1e0bc16
  random-zebra:
    utACK 1e0bc16 and merging...

Tree-SHA512: aa82d6f473d7ff6b65f04e590eb5dcfbcb5c1f22635bc22f0204ef3c23adcca99f95fc16d0b838c7358d6b832a4c55d43bf5f255902ea7fea4f5ff6216ea1423

23c9b6c Swap to newer method for genesis calculation; introduce Consensus namespace.. (barrystyle)

Pull request description:

  This is PR is the forth part of breaking up bitcoin#1209 into individual narrow-focused PRs. Original commit(s) were cherry-picked from @barrystyle's initial pre-squashed branch and then re-squashed (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209)

  Input Commits:
  Fuzzbawls@041c9ee
  Fuzzbawls@5d7e61c
  Fuzzbawls@cf696e4
  Fuzzbawls@18ab8ef
  Fuzzbawls@0a8338b

  Note: I didn't retain any transitional or "fixup" commits, so this PR is a single commit which takes the overall changeset of the above commits, along with some cleanup of unused/unneeded code that was in the original overall changeset (not-implemented BIP9 chain parameters, for example).

  -------------------

  This PR does two things:
  2. Establishes the `Consensus` namespace skeleton, with a minimum number of chain parameters moved into the new namespace. Additional PRs should be opened after this is merged that handle the moving of other consensus-specific chain parameters in a concise and narrow-focused manner.
  2. Refactors the method for initializing the genesis block on each chain (Mainnet, Testnet, Regtest) to be a function call rather than an in-class manual crafting of the block.

ACKs for top commit:
  random-zebra:
    ACK 23c9b6c
  furszy:
    ACK 23c9b6c

Tree-SHA512: dae6e1d887ade18855c9f1d16f625ec6d6e1cab890fe50eb045835798bab5df55475cdb6ec2e41326e48c568649b13f5e13adc49d21cba097feda2193fd28970

bd49362 [Refactor] Move zerocoin checks out of main (Fuzzbawls)

Pull request description:

  This is PR is the final part of breaking up bitcoin#1209 into individual narrow-focused PRs. For this one, the original commit had too many merge conflicts, so it was easier/faster for me to just start from a clean slate and re-do the commit. (reference branch is at https://github.com/Fuzzbawls/PIVX/commits/pr-1209)

  Reference Commit:
  Fuzzbawls@547ca6c

  This moves all zerocoin checking methods out of main.cpp/h into two new
  files in the `consensus` subdir: zerocoin_verify.cpp/h

ACKs for top commit:
  random-zebra:
    utACK  bd49362
  furszy:
    rebase utACK bd49362.

Tree-SHA512: 2ea66411d17bd7a6659243540ff060b7613377bff09633a4d743ccd78fe03efa146c93ff05e68f2347e3202ef5d22c14ca336abb35cc0b7007814e490c0517d6

See Issue bitcoin#1209

Pull request description:

  See Issue bitcoin#1209