Skip to content

Conversation

freewil
Copy link
Contributor

@freewil freewil commented Apr 26, 2012

No description provided.

gavinandresen added a commit that referenced this pull request Apr 26, 2012
remove strange debug message from listsinceblock
@gavinandresen gavinandresen merged commit b2997dc into bitcoin:master Apr 26, 2012
coblee pushed a commit to litecoin-project/litecoin that referenced this pull request Jul 17, 2012
remove strange debug message from listsinceblock
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request May 6, 2020
aa7ff86 [GUI][Wallet] Use unlock context for HD upgrade (random-zebra)
060790f [Doc] Add Context Lock/Unlock to release notes (random-zebra)
dee68e3 [Refactor] Use isWalletUnlocked() to check valid in requestUnlock() (random-zebra)
556a176 [GUI][Model] Remove verifyWalletUnlocked and connect everything (random-zebra)
1c803f0 [UI][Model] Connect WalletModel::requireUnlock (random-zebra)
31cbef7 [Refactor] Rename ...AnonymizationOnly --> ...StakingOnly (random-zebra)
1a7aa56 [Cleanup] Remove un-used walletpassworddialog (random-zebra)
a85deb7 [Wallet][Model] Fix and refactor UnlockContext (random-zebra)
05b1360 [Trivial] Styling: spaces and brackets (random-zebra)

Pull request description:

  Fix `UnlockContext` class and connect it where needed.
  Now, once an action requires the wallet to be fully unlocked, the askpassphrase dialog is presented to the user (if the status is "Locked" or "UnlockedForStaking"). This way, the password can be entered directly, and the operation can resume without needing additional clicks by the user.
  The previous locking status is restored when the action completes.

  Interested flows:
  - Send transaction (closes bitcoin#1365)
  - Create New Receive Address
  - Create New Payment Request
  - Create Masternode Controller
  - Create Cold Staking Address (closes bitcoin#1171)
  - Send Cold Stake Delegation
  - Wallet Data: Add multisend recipient
  - Tools: Sign Message
  - Tools: BIP38 tool
  - Upgrade wallet to HD

  Also
  Closes bitcoin#553
  Closes bitcoin#1035
  And maybe bitcoin#1152 becomes not needed now.

ACKs for top commit:
  Fuzzbawls:
    ACK aa7ff86

Tree-SHA512: 21590ca025b8c3a26824fea9c1107b68e0508cc080acbf0e1bf5b1c86da15f5f6696ea680c57989cc0cb8b5f54d328f32a60d24dc3c5ca8526179ef1750b3482
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants