-
Notifications
You must be signed in to change notification settings - Fork 37.7k
Redundant check in rpc.cpp #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be placed in the top level dir during release.
sipa
referenced
this pull request
in sipa/bitcoin
Dec 4, 2014
b0210a9 Merge pull request bitcoin#135 ee3eb4b Fix a memory leak and add a number of small tests. 4d879a3 Merge pull request bitcoin#134 d5e8362 Merge pull request #127 7b92cf6 Merge pull request bitcoin#132 0bf70a5 Merge pull request bitcoin#133 29ae131 Make scalar_add_bit test's overflow detection exact 9048def Avoid undefined shift behaviour efb7d4b Use constant-time conditional moves instead of byte slicing d220062 Merge pull request bitcoin#131 82f9254 Fix typo 601ca04 Merge pull request #129 35399e0 Bugfix: b is restricted, not r c35ff1e Convert lambda splitter to pure scalar code. cc604e9 Avoid division when decomposing scalars ff8746d Add secp256k1_scalar_mul_shift_var bd313f7 Merge pull request #119 276f987 Merge pull request #124 25d125e Merge pull request #126 24b3c65 Add a test case for ECDSA recomputing infinity 32600e5 Add a test for r >= order signature handling 4d4eeea Make secp256k1_fe_mul_inner use the r != property be82e92 Require that r and b are different for field multiplication. 597128d Make num optional 659b554 Make constant initializers independent from num 0af5b47 Merge pull request #120 e2e8a36 Merge pull request #117 c76be9e Remove unused num functions 4285a98 Move lambda-splitting code to scalar. f24041d Switch all EC/ECDSA logic from num to scalar 6794be6 Add scalar splitting functions d1502eb Add secp256k1_scalar_inverse_var which delegates to GMP b5c9ee7 Make test_point_times_order test meaningful again 0b73059 Switch wnaf splitting from num-based to scalar-based 1e6c77c Generalize secp256k1_scalar_get_bits 5213207 Add secp256k1_scalar_add_bit 3c0ae43 Merge pull request #122 6e05287 Do signature recovery/verification with 4 possible recid case e3d692f Explain why no y=0 check is necessary for doubling f7dc1c6 Optimize doubling: secp256k1 has no y=0 point 666d3b5 Merge pull request #121 2a54f9b Correct typo in comment 9d64145 Merge pull request #114 99f0728 Fix secp256k1_num_set_bin handling of 0 d907ebc Add bounds checking to field element setters bb2cd94 Merge pull request #116 665775b Don't split the g factor when not using endomorphism 9431d6b Merge pull request #115 e2274c5 build: osx: attempt to work with homebrew keg-only packages git-subtree-dir: src/secp256k1 git-subtree-split: b0210a9
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Mar 26, 2016
[walletdb] Add missing LOCK() in Recover() for dummyWallet
deadalnix
pushed a commit
to deadalnix/bitcoin
that referenced
this pull request
Oct 15, 2016
move two locks that are taken in AcceptConnection() closer to where the variables computed within the locked sections are used. This increases the possibility these locks are not taken as several checks higher in the function return before these variables/locks are needed. Specifically the CNode:IsBanned() check could return much more frequently during a DoS attack due to the new ban rules relating to too many connection attempts in too short a time, or too many evictions due to inactivity.
deadalnix
pushed a commit
to deadalnix/bitcoin
that referenced
this pull request
Jan 19, 2017
e2274c5 build: osx: attempt to work with homebrew keg-only packages (Cory Fields)
Closed
classesjack
pushed a commit
to classesjack/bitcoin
that referenced
this pull request
Jan 2, 2018
Reindex fails (Qtum Core / issue#112)
cryptapus
added a commit
to cryptapus/bitcoin
that referenced
this pull request
Oct 2, 2018
merge to 0.14 branch for release
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Feb 23, 2019
Added bounding check for vector in GetWitnessCommitmentIndex
rajarshimaitra
pushed a commit
to rajarshimaitra/bitcoin
that referenced
this pull request
Aug 5, 2021
…alization Replace "Gossip protocol" with "gossip protocol"
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the diff. It's an effectively useless if clause.