Make GetDataDir return absolute paths #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this resolve symbolic links? (I don't think that is proper behaviour, if so) |
|
I don't think boost::filesystem::system_complete does that. This commit changes the behaviour back to what it was before ee12c3d (except that the suggested bitcoin.conf file in case of a missing rpcpassword now has the correct file path). |
|
This breaks the UI build :-) (There's also a call to ReadConfigFile there that assumes that the result is a bool). |
|
Fixed. |
|
ACK |
2 similar comments
|
ACK |
|
ACK |
sipa
added a commit
that referenced
this pull request
Apr 22, 2012
Make GetDataDir return absolute paths
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
Make GetDataDir return absolute paths
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
…in#1133) * Fixes bitcoin#765 - Wallet balance was not updating correctly. When sending to ourselves using a public label the wallet was not updating correctly in the UI and was not showing up in the recent transactions list. * Fix spurious failure: validateblocktemplate.py Make sure nodes are sync'd properly before proceeding.
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Dec 25, 2019
…fixed. a25afdc [Bug][GUI] Fix, topbar sync progressbar expanded with the expandable view. (furszy) Pull request description: The sync progressBar was not been expanded following the sync expandable button size. This PR fixes it. Solving bitcoin#1090 ACKs for top commit: Fuzzbawls: ACK a25afdc random-zebra: ACK a25afdc Tree-SHA512: 834ce61a1caa4b709c8762d6d8c3538ce68ed99b188fd913610a3b2d922c6331a636fad90873decfd86d0a74cb554c6ae101d2da2c7c3ab1a310494cd9d9506c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1125.