Skip to content

[tests] Cleanup wildcard imports in functional tests #11274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[tests] Cleanup wildcard imports in functional tests #11274

wants to merge 1 commit into from

Conversation

mess110
Copy link
Contributor

@mess110 mess110 commented Sep 7, 2017

  • Unless it makes sense (p2p-compactblocks, p2p-fullblocktest, p2p-segwit, replace-by-fee)
  • Also remove double new lines
  • Remove whitespaces

@mess110
Cleanup wildcard imports in functional tests
9514e9e 
* Unless it makes sense
* Also remove double new lines
* Remove whitespaces
@fanquake fanquake added the Tests label Sep 7, 2017
@laanwj
Copy link
Member

laanwj commented Sep 7, 2017 •
edited
Loading

Thanks for your contribution.

However this was discussed before, last time in #9876, and back then it was decided not to do this.

@maflcko
Copy link
Member

maflcko commented Sep 7, 2017

Thanks. Though, this looks like a duplicate of #10366

@maflcko maflcko closed this Sep 7, 2017
@mess110 mess110 deleted the cleanup-wildcard-in-functional-tests branch September 7, 2017 21:48
@mess110
Copy link
Contributor Author

mess110 commented Sep 7, 2017

Always search before doing work, always search before doing work, always sea...

@mess110 mess110 restored the cleanup-wildcard-in-functional-tests branch September 12, 2017 21:29
@jnewbery jnewbery mentioned this pull request Apr 22, 2018
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mess110 @laanwj @maflcko @fanquake