extension of #1103: encapsulate mapCommands in CRPCTable #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK |
1 similar comment
|
ACK |
|
I added a commit that moves the definition of CRPCTable and CRPCCommand to bitcoinrpc.h, so that it does not need to be duplicated in tests/rpc_tests.cpp. I suppose it is useful for #1075 as well. re-ACK? |
|
ACK |
1 similar comment
|
ACK |
sipa
added a commit
that referenced
this pull request
Apr 21, 2012
extension of #1103: encapsulate mapCommands in CRPCTable
coblee
pushed a commit
to litecoin-project/litecoin
that referenced
this pull request
Jul 17, 2012
extension of bitcoin#1103: encapsulate mapCommands in CRPCTable
suprnurd
pushed a commit
to chaincoin-legacy/chaincoin
that referenced
this pull request
Dec 5, 2017
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Jan 22, 2019
[potentially WIP, discussion needed] Configure and boost fixes
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
Dec 25, 2019
…alidator. 8341d7e [GUI] Use QRegexValidator instead of the QDoubleValidator to validate QEditLine amounts. (furszy) Pull request description: Have received reports from linux users experiencing problems with the amount editable box, not being able to write large numbers with decimals (even when the QDoubleValidator decimal limit was set to 8..). Have checked it in macOS and everything is fine there, so.. the issue is pointing to an internal QT QDoubleValidator class problem that has nothing to do with our UI code in some linux distributions. To solve it without over complicate the code, have changed the QDoubleValidator for a QRegexValidator. Running fine in linux now too here, more eyes are welcome. ACKs for top commit: random-zebra: ACK 8341d7e Fuzzbawls: ACK 8341d7e Tree-SHA512: 908451fc8f2f8b4b23d0d00ba4199e2ba24367bfa509bffc4518d6f0d7b225067ce712a544fb94cbe2d7db2313256f82e7f809cf9ca076a724a2d1c42eba9c25
lateminer
pushed a commit
to lateminer/bitcoin
that referenced
this pull request
May 6, 2020
de45ddc [GUI] MnWizard: validate IP (random-zebra) 0e3c18f [GUI][Bug] MnWizard: Fix validators for masternode alias and port (random-zebra) Pull request description: First commit fixes the masternode alias: right now only letters and digits are allowed, but special characters (except spaces and hash marks) should be allowed too. It also replaces deprecated `QRegExp` with `QRegularExpression` (as per bitcoin#1124) and fixes the port number to the default. Closes bitcoin#1471 Second commit introduces validation for masternode IP addresses: they should be valid IPv4, IPv6 or .onion addresses and, if not on regtest, they should be reachable and routable. A unit test for the new `validateMasternodeIP` function is added to netbase_tests. Also removes the validation for the port, since it's fixed to network-default. ACKs for top commit: Fuzzbawls: ACK de45ddc furszy: ACK de45ddc Tree-SHA512: f9479483e4d41b80b83b4ca5cd57912dc027e020b92034090e9e1d01a1486696d70ce2fc3cf7253c18cdfcda273f5e203929a3e240f9d3d660b110c3bd009ef8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.