Allow Qt to wrap long tooltips (fixes #1063) #1090
Conversation
|
So Try it with the current version, if you hover the lock-icon if your wallet is encrypted. This is rich text, but looks kind of ugly, because of the small width of the tooltip. |
|
I'm not sure where it gets the default width from (which is indeed extremely narrow). Couldn't find any documentation about that. That leaves looking in the Qt source I guess... |
|
But you could verify that the default is to narrow, so this is no Win specific behaviour? |
|
No, it isn't specific to any OS. This seems to make the tooltips wider (crazily wide, in this case), for example: |
|
I've added a min-width of 350px, this looks like a nice tradeoff between too narrow and too wide. |
|
Tried it and it's way better than before, I agree it's a nice tradeoff until we comeup with a even nicer solution in the future :). |
|
Shouldn't worry too much about this, there's way more serious issues to solve first. |
|
ACK |
|
This should get in 0.6.1 as the detach db tooltip is quite long ;). |
|
No, I don't think it's a good idea to merge this between release candidates. That's only for critical bugfixes. There's the possibility that this introduces problems in some place / language so it needs testing. Better to merge it after 0.6.1. |
|
It was targetted for 0.6.1 and I reminded of that fact ;). There are quite a few commits that could have been merged in before the RC1. |
|
This makes tooltip windows too wide sometimes: |
|
Yea, it only works if a minimum width is set, otherwise it makes them too |
Implemented without having to touch any translation: by listening for QEvent::ToolTipChange events, then rewriting the tooltips to prefix `<qt/>` if it is not yet rich text.
|
Rebased, and added a useful heuristic to only do this for long tooltips, where "long" is defined as longer than a certain length in characters. This fixes @luke-jr's issue. |
|
ACK |
Allow Qt to wrap long tooltips (fixes #1063)
Allow Qt to wrap long tooltips (fixes bitcoin#1063)
…fixed. a25afdc [Bug][GUI] Fix, topbar sync progressbar expanded with the expandable view. (furszy) Pull request description: The sync progressBar was not been expanded following the sync expandable button size. This PR fixes it. Solving bitcoin#1090 ACKs for top commit: Fuzzbawls: ACK a25afdc random-zebra: ACK a25afdc Tree-SHA512: 834ce61a1caa4b709c8762d6d8c3538ce68ed99b188fd913610a3b2d922c6331a636fad90873decfd86d0a74cb554c6ae101d2da2c7c3ab1a310494cd9d9506c
3a9e113 Only evaluate fee cache, when it's activated (dexX7) Pull request description: The fee cache used for the fee distribution is only needed, when the feature of fee distribution is activated. When this is not the case, it's just a performance burdon, which can easily take 0.3 additional seconds, when a new block is processed. Tree-SHA512: 13167bac8df157f2ddfe977b6fb68b1ba69439ce300d98b25c0356277e032ba0f40eb093720efb4e8fec9e2b3406febef98cdb3c8b2f902274106594793e99ec
Allow Qt to word-wrap tooltips, should fix #1063. Qt can only word-wrap rich text messages.
Implemented without having to touch any translation: by listening for QEvent::ToolTipChange events, then rewriting the tooltips to prefix
<qt/>and convert to rich text if it is not yet rich text.