-
Notifications
You must be signed in to change notification settings - Fork 37.7k
fix for #945 #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix for #945 #1032
Conversation
… Qt tags for font settings
I we want this before 0.7 I could do this via transifex and a copy & paste of the translated word "Wallet" for the used languages directly from the current lang-files. Before I would create a pull for the new en master file, so tf can fetch it from here. |
Any reason not to merge this yet? |
It would mess up the word "Wallet" in all translations with no clear immediate gain. Better to merge it after 0.6.1 is released to give translators some time. |
Diapolo did volunteer to adjust the translations, and it seems to fit well into the "cleanup" purpose of 0.6.1. |
How was the timeline for 0.6.1? I was off for 7 days and will re-start helping during the next days. |
As we have 0.6.1 final released I would like to get this merged asap, so we can rely on the translators :). Transifex just needs an updated en master file afterwards. |
Remove HTML font crap from "Wallet" message (fix for #945)
Remove HTML font crap from "Wallet" message (fix for #945)
…odes by rank/score (bitcoin#1032)
…und task error catching. 38c654b [GUI] Dashboard hasStakes variable set when the view is loaded and/or when the first stake is received. Don't use the stake filter proxy which can or can't have stakes (always changing and being filtered). (furszy) 6f91049 [GUI] Background task catching errors that have no information about. (furszy) 72966c9 [GUI] Dashboard chart, covering edge empty list problem. (furszy) Pull request description: PR covering an empty list pointer segfault when the wallet has no stakes on the yearly filtered data when, for some reason, the chart got visible (when it shouldn't as there are no stakes..). It happened to me when was doing a reindex and the internal wallet state is not clear/final. Plus added a catch all in the background worker to not crash and inform to the user if there was an unexpected error running any UI background task. ACKs for top commit: random-zebra: ACK 38c654b Fuzzbawls: ACK 38c654b Tree-SHA512: b918700f9c97d78f131285b8b88dca28d9e9bb8a65dcd33e95d10e89f233d0ce0cc86b39f65794d836f487d2e119d5091aedb28a22bc3638417fd60421d98a88
This one fixes #945 by removing the HTML code around "Wallet" (displayed on overview page) and use the corresponding Qt designer tags for the font settings.
Hint: Manual retranslation of the word Wallet or early push to a fresh en master file to get it re-translated!