-
Notifications
You must be signed in to change notification settings - Fork 37.7k
adhere to -whitelist
for outbound connection
#10051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Outbound connections are already privileged in a number of ways, and the white-listing by default has strange effects on transaction propagation that you probably don't want for outbound connections. |
the reason for wanting to whitelist the outbound connection is cuz I'm using I think you might have misunderstood as well based on the title, the PR Is to adhere to the |
-whitelist
for outbound connection
I agree this would be useful. |
Oops, missed that this was a PR, not an issue. This happens to be exactly what I need for my tests, thanks! We might consider using a different option for outgoing network ranges to whitelist, though. It can be unexpected to users if this is merged as-is, as it widens the meaning of an (arguably ill-defined) existing option. |
@laanwj Agreed on all points. I've hacked this in for myself a few times for addnode=/connect= nodes. But as you said, tacking it on to whitelist is moving in the wrong direction. I'd much prefer to get rid of whitelist and replace it with explicit privileges, generated at connection time based on inbound/outbound, config options, etc. That way there's less guessing in the later code, and there's a single place for the logic. I can whip that up if you agree. |
Whitelisting isn't really the correct fix for single outbound connect=1 resulting in slower relay. |
I'd prefer that too. Something like, say, a bit field. The current whitelist is both too fine-grained and too course-grained. It's just vague what it does and different people want different things from it, and we can't change it without breaking other people's use cases. |
hmm, for me the whitelist makes sense cuz I can easily ensure it covers my local servers without too much ufss |
There seems to be no agreement to do this, and quite a lot of time elapsed without new discussion, so I'm closing. Looking forward to alternative solutions as were discussed in this PR. |
unsure why this wasn't already being done, seems sensible to me that you also want to be able to whitelist nodes that you make an outgoing connection to?
trying to figure if there should be any tests added but I can't seem to find tests that really cover ConnectNode specifically at all?