Flush dbcache early if system is under memory pressure #19873
Conversation
|
Concept ACK I think this is a neat idea. You do need a way to disable this during the tests though, to assure deterministic behaviour that doesn't depend on system circumstances (see Travis). |
|
Concept ACK |
|
Added logging, a config option, and fixed test (and took out of Draft) |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
dfa841c to
666994e
Compare
No point forcing memory to get pushed out to swap just to cache db changes when we can write the db changes out instead
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
|
Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened. |
|
This continues to be updated and maintained for Knots. Feel free to reopen it if anyone shows interest in reviewing for Core. (Ping me if I need to push an older commit temporarily to reopen) |
No point forcing memory to get pushed out to swap just to cache db changes when we can write the db changes out instead
Chasing Concept ACKs and opinions on approach taken(no longer draft)One eventual goal might be to (on systems where this is supported) allow dbcache to be unlimited.