test: move TEST_RUNNER_EXTRA into native tsan setup #19412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx. Good catch! |
|
ACK a92e48b |
|
Looks like the bug has been introduced in commit fa74a54 |
|
ACK a92e48b -- patch looks correct Good catch! |
|
Looks like the first run passed, but it took more than 2 hours: https://travis-ci.org/github/bitcoin/bitcoin/jobs/703160129 Seems odd, but something to investigate later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature_block.pyis being run in the tsan job, i.e here, even though it should be excluded. My hasty assumption is that this will fix it. In any case, all other instances ofTEST_RUNNER_EXTRAseem to have moved out of.travis.ymland into the different CI configurations.