test: Fix intermittent test failure in feature_backwards_compatibility #19332
Conversation
fad2511 to
5555b7e
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Linear transaction relay is a feature. We want to make sure new nodes don't ban old nodes and vice versa. Especially if we add some interesting transactions to this test. I would prefer if there was a more fine grained permission than |
5555b7e to
fa68596
Compare
|
Rebased and removed mention of travis in the pull request description |
|
Oh I think I misread the description: I though you wanted to get rid of linear relay, but you're just getting rid of the random delays. That's fine. I cherry-picked this into #19013, which would save me from having to rebase this across lots of commits. |
There was a problem hiding this comment.
Tested ACK fa68596
As expected and mentioned in the PR description, this fix also speeds up the test tremendously. On my Debian machine:
master:
$ time ./test/functional/feature_backwards_compatibility.py
real 1m18.605s
user 0m3.054s
sys 0m1.593s
PR branch:
$ time ./test/functional/feature_backwards_compatibility.py
real 0m5.541s
user 0m1.875s
sys 0m1.220s
|
🐙 This pull request conflicts with the target branch and needs rebase. Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft". |
All nodes are connected linearly, so tx relay not only makes the test slow, but also intermittently failing (timing out).
Fixes #18969.
Fix both issues by enabling immediate tx relay.