Skip to content

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented May 19, 2020

Original branch merges cleanly (no rebase needed)

See also #17946

@jnewbery
Copy link
Contributor

utACK 412d5fe

@fanquake
Copy link
Member

These commits are missing the Github-Pull and Rebased-From metadata that we normally add to backports.

@maflcko
Copy link
Member

maflcko commented May 20, 2020

The commit were written before the branch (and are located on top of a common ancestor of master+0.20) , so I think the script doesn't need the metadata.

@luke-jr
Copy link
Member Author

luke-jr commented May 20, 2020

@fanquake This isn't a backport per se; it's the original branch, exactly the same commits just merged into master.

@kcalvinalvin
Copy link
Contributor

kcalvinalvin commented May 20, 2020

Appveyor is failing a test because the commit that fixed the error isn't included in this branch.

This commit is included in the 0.20 branch.

All tests passed on my local machine when git cherry-picked the commit to this branch.

@maflcko
Copy link
Member

maflcko commented May 26, 2020

This is a two-line code fix with a two-line test. The risk of breaking something is low, so I think this can go into final without another rc. Thoughts?

@laanwj laanwj modified the milestones: 0.20.0, 0.20.1 May 26, 2020
@laanwj
Copy link
Member

laanwj commented May 26, 2020

I would strongly prefer not to include any code change (no matter how minor) to the binaries in -final that is not in any rc.
As this is not a regression in 0.20, I think this can wait until 0.20.1.
(unless, of course, there happens to be need another rc for 0.20.0 then it can go in anyway)

@maflcko maflcko merged commit e42c959 into bitcoin:0.20 Jun 2, 2020
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants