gui: remove assert in walletcontroller & run setparent in gui-qt main thread #18961
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
| } else { | ||
| // Handler callback runs in a different thread so fix wallet model thread affinity. | ||
| wallet_model->moveToThread(thread()); | ||
| bool invoked = QMetaObject::invokeMethod(this, "addWallet", Qt::QueuedConnection, Q_ARG(WalletModel*, wallet_model)); |
There was a problem hiding this comment.
I was going to suggest to use Qt::BlockingQueuedConnection instead, so that the caller gets the wallet model with the parent already set.
There was a problem hiding this comment.
i think - it stucks on windows if u do Blocking. Need to check more, but not today.
| // Handler callback runs in a different thread so fix wallet model thread affinity. | ||
| wallet_model->moveToThread(thread()); | ||
| wallet_model->setParent(this); | ||
|
|
| return wallet_model; | ||
| } | ||
|
|
||
| void WalletController::addWallet(WalletModel* wallet_model) | ||
| { | ||
| // Take ownership of the wallet model and register it. |
There was a problem hiding this comment.
comment must be updated,too (setparent & emit to update gui), ownership already done in if-clause and register was in m_wallets.push_back(wallet_model) - if u change more in walletcontroller.cpp, u should change it.
small fix, u should use setparent() call in qt only if u own the object (thread created the object).