Skip to content

Fix -Wsign-compare warning on ARM 32-bit #18686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix -Wsign-compare warning on ARM 32-bit #18686

wants to merge 1 commit into from

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Apr 17, 2020

This PR fixes -Wsign-compare warning on ARM 32-bit platform which is emitted on master (54f812d) by different compilers:

  • GCC:
  CXX      util/libbitcoin_util_a-asmap.o
util/asmap.cpp: In function ‘uint32_t Interpret(const std::vector<bool>&, const std::vector<bool>&)’:
util/asmap.cpp:82:26: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
                 if (jump >= endpos - pos) break;
                     ~~~~~^~~~~~~~~~~~~~~
  CXX      util/libbitcoin_util_a-bytevectorhash.o
  • Clang:
  CXX      util/libbitcoin_util_a-asmap.o
util/asmap.cpp:82:26: warning: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'std::ptrdiff_t' (aka 'int') [-Wsign-compare]
                if (jump >= endpos - pos) break;
                    ~~~~ ^  ~~~~~~~~~~~~
  CXX      util/libbitcoin_util_a-bytevectorhash.o
1 warning generated.

@maflcko
Copy link
Member

maflcko commented Apr 17, 2020

Please suggest the change in the open asmap pr

@hebasto
Copy link
Member Author

hebasto commented Apr 17, 2020 •
edited
Loading

Please suggest the change in the open asmap pr

Done: #18512 (comment)

@hebasto hebasto closed this Apr 17, 2020
@hebasto hebasto mentioned this pull request Apr 17, 2020
Merged
@hebasto hebasto mentioned this pull request May 9, 2020
Merged
@hebasto
Copy link
Member Author

hebasto commented May 11, 2020

The issue is fixed by eac6a30.

@hebasto hebasto deleted the 200417-arm-sign branch May 11, 2020 04:33
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Utils/log/libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hebasto @maflcko @DrahtBot