Concept ACK (leaving aside for now the question of inclusion in the codebase).

Concept ACK. I think it makes sense for us to have this tool inside the repo, if we want to encourage using asmap, and improve the auditability/maintenance.

Did some slight code review, will do more if/when we get enough Concept ACKs.

Also, I will probably post this separately, but anyone who speaks rust is welcome to review our tool (https://github.com/i7i/asmap-rs) for aggregating routing info from various sources :)

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• Improve asmap checks and add sanity check #18512 (Improve asmap checks and add sanity check by sipa)
• util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting #18450 (util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting by practicalswift)
• Serialization improvements step 6 (all except wallet/gui) #18317 (Serialization improvements step 6 (all except wallet/gui) by sipa)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Added lots of comments, and improved the encoder algorithm. I believe it will now always find the smallest encoding (in a few seconds, for realistic inputs).

Concept ACK

+0 for having it in the repo, Concept ACK

Ideally it should be in another repo, but maybe we're not ready for that yet if it shares a lot of code.

🐙 This pull request conflicts with the target branch and needs rebase.

It might be worth building this on top of #19937 as part of bitcoin-util.

Concept ACK on including something this into the codebase, ideally along with some instructions which are a bit sparse now. Unless you suspect this needs tons of tweaking in the future, in which case perhaps a separate repo is better. Or if the output can be used by other software than Bitcoin Core.

@Sjors I had the same problem with the lack of clear instructions so I created a Vagrantfile that performs all the steps in one go.

It's located at https://github.com/lestephane/vagrant-asmap

You run vagrant up, and after a while, if your machine has the minimum specs to run the bottleneck analysis (12GB RAM seems to be needed for me), you end up with an ip_asn.map file.

• Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
• Is it no longer relevant? ➡️ Please close.
• Did the author lose interest or time to work on this? ➡️ Please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future.

Concept ACK

I'm working on some tooling to help with map comparisons between releases and some user experience improvements to asmap-rs.

Although certainly we'll have an encoded map included with every release when asmap is enabled by default, I think it still makes sense to include bitcoin-asmap in this repo for easier maintenance and discoverability. It's just less hassle for node operators who may be interested generating and encoding their own mappings too.

Closing. I'm working on external tooling for working with asmap files in https://github.com/sipa/asmap/tree/nextgen (encode, decode, diff, bottleneck, ...).