The issue with changing translated strings is that all translations in all languages get discarded. This has to be weight against the benefit of the new string.

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• qt: Add Create Unsigned button to SendConfirmationDialog #18789 (qt: Add Create Unsigned button to SendConfirmationDialog by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

It's too late for 0.20.0, the strings and translations freeze are past. Could consider after the branch-off though.

I prefer the new (in this PR) text. Seems more clear and user focused. Comparing screenshots would be nice.
utACK 7237f92 (for 0.21).

I prefer the new (in this PR) text. Seems more clear and user focused. Comparing screenshots would be nice.
utACK 7237f92 (for 0.21).

Here is the modal pre-change:

Here is the modal post-change:

The changes aren't too noticeable on Mac, it's more for Windows/Linux, which make use of the windowTitle property.

"signaling" at least should be lowercase

I'm not sure the BIP 125 reference is obsolete, though - it's the specification itself for a policy, not a one-off change.

Needs rebase.

I'm getting post-rebase build errors consistent with the CI. @dannmat mind taking a look?

qt/sendcoinsdialog.cpp:337:13: error: use of undeclared identifier 'questionString'; did you mean 'question_string'?
            questionString.append(tr("You can increase the fee later (Signaling Replace-By-Fee)."));
            ^~~~~~~~~~~~~~
            question_string
qt/sendcoinsdialog.cpp:223:48: note: 'question_string' declared here
bool SendCoinsDialog::PrepareSendText(QString& question_string, QString& informative_text, QString& detailed_text)
                                               ^
qt/sendcoinsdialog.cpp:339:13: error: use of undeclared identifier 'questionString'; did you mean 'question_string'?
            questionString.append(tr("You cannot increase the fee later (Not signalling Replace-By-Fee)"));
            ^~~~~~~~~~~~~~
            question_string
qt/sendcoinsdialog.cpp:223:48: note: 'question_string' declared here
bool SendCoinsDialog::PrepareSendText(QString& question_string, QString& informative_text, QString& detailed_text)

Yep I can take a look at this 👍

Hi @dannmat. This is a fairly simple wording change, but as-is, it doesn't compile, and the commits needs cleaning up. If you do still want to follow up with this change, I'm going to suggest re-opening your PR in the gui repo: https://github.com/bitcoin-core/gui. There are currently a few other tooltip/text related PRs open there as well.

Hi @fanquake. Sorry I didn't get chance to clean this commit up. I'll re-open this in the new gui repo.

Thanks,
Matt